Fix instructor notes 505 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting the fix, Kelly!
The other two failed tests have to do with the fact that 533d019 accidentally deleted a snapshot test (probably because it was skipped on windows). Now that pandoc is more reliably set up for windows, it may be worthwhile revisiting the tests that skip on windows for pandoc, but for now, i will reinstate that snapshot |
zkamvar
reviewed
Aug 30, 2023
Co-authored-by: Zhian N. Kamvar <[email protected]>
|
Thanks @zkamvar! I've committed your suggestions. If the tests pass and you think its ready, feel free to merge. |
|
Congratulations, @klbarnes20 you have your first contribution to sandpaper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #505. It adds a test for when instructor notes is empty and an else clause to the build_instructor_notes.R.
When I ran the test before the fix, it failed. When I ran it after, that particular test passed. I still have two other failed tests, but not sure they are related to this issue/fix.